Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Volume Offset property to GoXlrChannelSyncFilter #30

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Add Volume Offset property to GoXlrChannelSyncFilter #30

merged 2 commits into from
Feb 8, 2025

Conversation

parzival-space
Copy link
Owner

This adds the requested functionality as per #26

@parzival-space parzival-space added the enhancement New feature or request label Feb 8, 2025
KevinOrtmann
KevinOrtmann suggested changes Feb 8, 2025
View reviewed changes
Copy link

@KevinOrtmann KevinOrtmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log statements from lines 111-114 are executed continuously (each frame), which causes the log to be unnecessarily filled.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KevinOrtmann
KevinOrtmann approved these changes Feb 8, 2025
View reviewed changes
Copy link

@KevinOrtmann KevinOrtmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parzival-space parzival-space merged commit f0fc2d4 into development Feb 8, 2025
6 checks passed
@parzival-space parzival-space deleted the feature/26-volume-offset branch February 8, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinOrtmann KevinOrtmann KevinOrtmann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parzival-space @KevinOrtmann