Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of derivative with educe. #518

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Nov 16, 2024

Fix the following as reported by cargo deny check

error[unmaintained]: `derivative` is unmaintained; consider using an alternative
   ┌─ /Users/joshps/work/partiql-lang-rust/Cargo.lock:55:1
   │
55 │ derivative 2.2.0 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
   │
   ├ ID: RUSTSEC-2024-0388
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0388
   ├ The [`derivative`](https://crates.io/crates/derivative) crate is no longer maintained.
     Consider using any alternative, for instance:
     - [derive_more](https://crates.io/crates/derive_more)
     - [derive-where](https://crates.io/crates/derive-where)
     - [educe](https://crates.io/crates/educe)
   ├ Announcement: https://github.com/mcarton/rust-derivative/issues/117
   ├ Solution: No safe upgrade is available!
   ├ derivative v2.2.0
     └── partiql-types v0.11.0

Cf. mcarton/rust-derivative#117


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (75ffa06) to head (fef21fd).
Report is 2 commits behind head on dev-ion-doc.

Files with missing lines Patch % Lines
partiql-parser/src/parse/parse_util.rs 83.67% 5 Missing and 3 partials ⚠️
partiql-ast/src/ast.rs 0.00% 4 Missing ⚠️
partiql-types/src/lib.rs 40.00% 0 Missing and 3 partials ⚠️
partiql-logical-planner/src/lower.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           dev-ion-doc     #518      +/-   ##
===============================================
+ Coverage        80.70%   80.75%   +0.04%     
===============================================
  Files               88       88              
  Lines            19409    19483      +74     
  Branches         19409    19483      +74     
===============================================
+ Hits             15665    15734      +69     
- Misses            3324     3326       +2     
- Partials           420      423       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Conformance comparison report

Base (341e05f) e1cb1b6 +/-
% Passing 86.98% 86.98% 0.00%
✅ Passing 5564 5564 0
❌ Failing 833 833 0
🔶 Ignored 0 0 0
Total Tests 6397 6397 0

Number passing in both: 5564

Number failing in both: 833

Number passing in Base (341e05f) but now fail: 0

Number failing in Base (341e05f) but now pass: 0

Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious on the differences between the suggested replacement crates:

Base automatically changed from feat-ast-literals to dev-ion-doc November 18, 2024 19:22
@jpschorr
Copy link
Contributor Author

jpschorr commented Nov 18, 2024

Curious on the differences between the suggested replacement crates:

* [derive_more](https://crates.io/crates/derive_more)

* [derive-where](https://crates.io/crates/derive-where)

* [educe](https://crates.io/crates/educe)

I didn't research extensively, because educe is the only one that, as far as I can see, derives Hash with the ability to reference a method.

@jpschorr jpschorr merged commit a3aeaf9 into dev-ion-doc Nov 18, 2024
18 of 19 checks passed
@jpschorr jpschorr deleted the chore-replace-derivative branch November 18, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants