Fixes an ambiguity with identifiers and keywords. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `SELECTY` would be parsed as keyword `SELECT` identifier `Y`. This fixes the negative look-ahead assertion for keywords to make sure a non-quoted identifier character follows and similarly adds a look-ahead assertion for the prefix of identifiers to not be keywords (which includes the previous assertion). Also fixes a unit test name for identifiers.
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 90.60% 90.66% +0.05%
==========================================
Files 7 7
Lines 479 482 +3
==========================================
+ Hits 434 437 +3
Misses 45 45
Continue to review full report at Codecov.
|
marcbowes
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
SELECTYwould be parsed as keywordSELECTidentifierY. This fixes the negative look-ahead assertion for keywords tomake sure a non-quoted identifier character follows and similarly
adds a look-ahead assertion for the prefix of identifiers to not be
keywords (which includes the previous assertion).
Also fixes a unit test name.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.