Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes all DISTINCT conformance tests #1513

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Fixes all DISTINCT conformance tests #1513

merged 4 commits into from
Aug 7, 2024

Conversation

johnedquinn
Copy link
Member

@johnedquinn johnedquinn commented Jul 16, 2024 •
edited
Loading

Description

  • Fixes all DISTINCT conformance tests.
  • Fixes DISTINCT by using the PartiQLValueComparator.
  • Adds coll_<agg>_all and coll_<agg>_distinct variants.
  • I updated how we get unique CompilerTypes by adjusting the hashcode/equals. This fixes a bug where some literal nulls & missings would have the wrong types when they were added to a set.
  • Updates the NumbersExtensions to add support for BYTE and SHORT. I've also organized the extensions quite a bit to make it easier to understand.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnedquinn johnedquinn marked this pull request as ready for review July 24, 2024 18:44
@johnedquinn johnedquinn changed the title Fixes majority of DISTINCT conformance tests Fixes all DISTINCT conformance tests Jul 25, 2024
@johnedquinn johnedquinn force-pushed the v1-conformance-datum-distinct branch 2 times, most recently from 239a8df to d699fc3 Compare July 25, 2024 18:43
@johnedquinn johnedquinn marked this pull request as draft August 1, 2024 17:22
@johnedquinn johnedquinn force-pushed the v1-conformance-datum-distinct branch from d699fc3 to 8360e0e Compare August 6, 2024 20:41
@johnedquinn johnedquinn marked this pull request as ready for review August 6, 2024 22:30
alancai98
alancai98 reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments / questions. otherwise looks good

partiql-spi/src/main/kotlin/org/partiql/spi/fn/builtins/FnCollAgg.kt Show resolved Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/CompilerType.kt Outdated Show resolved Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/RexConverter.kt Outdated Show resolved Hide resolved
partiql-eval/src/main/kotlin/org/partiql/eval/internal/operator/rel/RelDistinct.kt Show resolved Hide resolved
This was referenced Aug 7, 2024
Open
Closed
@johnedquinn
Copy link
Member Author

@alancai98 I've created #1541 for the comparator. I've also added it to the internal tracker.

@johnedquinn johnedquinn merged commit e21a1eb into partiql:v1 Aug 7, 2024
7 checks passed
@johnedquinn johnedquinn deleted the v1-conformance-datum-distinct branch August 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alancai98 alancai98 alancai98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnedquinn @alancai98