Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks #1504 (Fix published jars for non-shadowed packages) #1505

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

alancai98
Copy link
Member

@alancai98 alancai98 commented Jul 10, 2024

(cherry picked from commit 6b49fc1)

Targets v1 branch and copies patch to partiql-eval branch.

Below description copied from #1504.

Relevant Issues

  • None

Description

  • Fixes the publishing of jars for non-shadowed packages. Previously, all the packages that don't shadow any packages would fatjar all the dependencies (e.g. kotlin, ion-element). With this change, we now exclude those dependencies, so the jar contains what was there previously.
  • Previous packages that shadowed certain dependencies (i.e. partiql-parser and partiql-lang-kotlin) did not have this issue
  • Testing
    • Ran publishToMavenLocal and compared the jars between 0.14.5 and this version
    • Published jars for this version do not have the extra dependencies and retain the existing APIs

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO] No api changes.

  • Any backward-incompatible changes? [NO]

  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 requested a review from yliuuuu July 10, 2024 00:24
@alancai98 alancai98 self-assigned this Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.57% 87.05% -5.52%
✅ Passing 5419 5097 -322
❌ Failing 435 758 323
🔶 Ignored 0 0 0
Total Tests 5854 5855 1
Number passing in both: 4894

Number failing in both: 232

Number passing in legacy engine but fail in eval engine: 526

Number failing in legacy engine but pass in eval engine: 203
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
203 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (5b86afc) 51923a2 +/-
% Passing 92.59% 92.57% -0.02%
✅ Passing 5420 5419 -1
❌ Failing 434 435 1
🔶 Ignored 0 0 0
Total Tests 5854 5854 0
Number passing in both: 5419

Number failing in both: 434

Number passing in Base (5b86afc) but now fail: 1

Number failing in Base (5b86afc) but now pass: 0
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • MYSQL_SELECT_23, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (5b86afc) 51923a2 +/-
% Passing 87.05% 87.05% 0.00%
✅ Passing 5097 5097 0
❌ Failing 758 758 0
🔶 Ignored 0 0 0
Total Tests 5855 5855 0
Number passing in both: 5097

Number failing in both: 758

Number passing in Base (5b86afc) but now fail: 1

Number failing in Base (5b86afc) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • Example 6 — Value Coercion, compileOption: LEGACY

@alancai98 alancai98 merged commit 7ed91d2 into v1 Jul 10, 2024
14 checks passed
@alancai98 alancai98 deleted the cp-1504 branch July 10, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants