Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
Previously, the class
StaticTypeMeta
is duplicated the ast package and in the lang package.Both of which get packaged under
org.partiql.lang.ast
.This fails the build when a customer enables compile time validation for duplicated class in the classpath.
This PR removes the
StaticTypeMeta
in the lang package as a short term fix for the issue.We anticipate issue of similar pattern will not occurs once we complete the split of packages, but it is still worthy for us to consider adding a check for similar issue in the future. Unfortunately, a cursor search does not reveal a good gradle-plugin for this purposes, hence this PR does not include such check.
Note that the issue only happens when a compile time check as described is included in the build process, this is because the two classes are identical and at runtime, it does not matter which class gets loaded...
Also, worth to call out that this PR should not be considered backward-incompatible:
This is: one can access the
StaticTypeMeta
is only taking dependency frompartiql-ast
package, and one can still accessStaticTypeMeta
when takiing dependency frompartiql-lang
package. The APIs are exposed becausepartiql-ast
is a dependency ofpartiql-lang
.Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Any backward-incompatible changes? [YES/NO]
errors for users that are using our public APIs or the entities that have
public
visibility in our code-base. >No.
Any new external dependencies? [YES/NO]
No.
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes.
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.