Remove unnecessary conversion steps in PartiQLValueIonReaderBuilder

[popematt]

Relevant Issues

N/A

Description

There is a lot of unnecessary computation in PartiQLValueIonReaderBuilder.build(ionElement: IonElement) as it converts from IonElement -> IonValue -> text Ion -> PartiQLValue. This PR eliminates the hop to IonValue, resulting in IonElement -> text Ion -> PartiQLValue.

// Current implementation
val reader = IonReaderBuilder.standard().build(ionElement.toIonValue(IonSystemBuilder.standard().build()))
val writer = IonTextWriterBuilder.standard().build(out)
writer.writeValues(reader) 

The IonReader in the current implementation is completely unnecessary. We can eliminate the construction and overhead of passing data through an IonReader by writing the IonValues directly to the writer.

val writer = IonTextWriterBuilder.standard().build(out)
ionElement.toIonValue(IonSystemBuilder.standard().build()).writeTo(writer)

The conversion to IonValue also adds a non-trivial amount of computation. The implementation of IonElement.toIonValue() constructs an IonWriter that will write directly to IonValue. We can take things one step further, and skip IonValue completely, which is what this PR does. I.e.:

val writer = IonTextWriterBuilder.standard().build(out)
ionElement.writeTo(writer)

Other Information

• Updated Unreleased Section in CHANGELOG: NO

CHANGELOG says:

All notable changes to this project will be documented in this file.

Is this PR "notable"? I'll let you be the judge.

• Any backward-incompatible changes? NO

• Any new external dependencies? NO

• Do your changes comply with the Contributing Guidelines and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[RCHowell]

Need to do a ./gradlew ktlint

[yliuuuu]

Good to know. Thanks for the detailed description.