Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply "PartiQL Eval - Planner Mode (#1385)" #1429

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Apply "PartiQL Eval - Planner Mode (#1385)" #1429

merged 3 commits into from
Apr 15, 2024

Conversation

rchowell
Copy link
Contributor

Description

Re-apply #1385

Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchowell rchowell requested a review from yliuuuu April 12, 2024 23:14
Copy link

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.52% 82.78% -9.75%
✅ Passing 5383 4816 -567
❌ Failing 435 1002 567
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 4643

Number failing in both: 262

Number passing in legacy engine but fail in eval engine: 740

Number failing in legacy engine but pass in eval engine: 173
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
173 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (04e33a8) b282bfe +/-
% Passing 92.51% 92.52% 0.02%
✅ Passing 5382 5383 1
❌ Failing 436 435 -1
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5382

Number failing in both: 435

Number passing in Base (04e33a8) but now fail: 0

Number failing in Base (04e33a8) but now pass: 1
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see
  • MYSQL_SELECT_29, compileOption: LEGACY

Conformance comparison report-Cross Commit-EVAL

Base (04e33a8) b282bfe +/-
% Passing 82.12% 82.78% 0.65%
✅ Passing 4778 4816 38
❌ Failing 1040 1002 -38
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 4739

Number failing in both: 963

Number passing in Base (04e33a8) but now fail: 39

Number failing in Base (04e33a8) but now pass: 77
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
77 test(s) were previously failing but now pass. Before merging, confirm they are intended to pass
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Copy link
Contributor

@yliuuuu yliuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rchowell rchowell merged commit 4b70b85 into v1 Apr 15, 2024
14 checks passed
@rchowell rchowell deleted the planner-mode branch April 15, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants