Adds more efficient internal pretty-printing #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (6da7496) but now fail: 0 Number failing in Base (6da7496) but now pass: 0 |
alancai98
reviewed
Mar 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
=========================================
Coverage 73.14% 73.14%
Complexity 2393 2393
=========================================
Files 247 247
Lines 17623 17623
Branches 3176 3176
=========================================
Hits 12890 12890
Misses 3856 3856
Partials 877 877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alancai98
reviewed
Mar 28, 2024
|
|
||
| /** | ||
| * Pretty-print this [AstNode] as SQL text with the given [SqlLayout] | ||
| */ | ||
| @JvmOverloads | ||
| @Deprecated("To be removed in the next minor version") |
There was a problem hiding this comment.
For these @Deprecated messages, should they say next major version?
Suggested change
| @Deprecated("To be removed in the next minor version") | |
| @Deprecated("To be removed in the next major version") |
alancai98
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
#1402
#1400
Description
This adds the improved pretty-printer behind the default public pretty-print function while keeping the existing Sql*.kt classes for backwards compatibility.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Yes
Any backward-incompatible changes? [YES/NO]
No
Any new external dependencies? [YES/NO]
No
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.