Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SqlDialect output for unary ops #1384

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

alancai98
Copy link
Member

Description

Applies fix to SqlDialect output for unary ops from partiql/partiql-scribe#22.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Mar 9, 2024
Copy link

github-actions bot commented Mar 9, 2024

Conformance comparison report

Base (5121093) b83acd1 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (5121093) but now fail: 0

Number failing in Base (5121093) but now pass: 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (5121093) to head (c605947).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1384   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity     2095     2095           
=========================================
  Files           221      221           
  Lines         15984    15984           
  Branches       2896     2896           
=========================================
  Hits          11534    11534           
  Misses         3641     3641           
  Partials        809      809           
Flag Coverage Δ
CLI 11.86% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alancai98 alancai98 merged commit b938fda into main Mar 9, 2024
10 checks passed
@alancai98 alancai98 deleted the fix-sqldialect-unary branch March 9, 2024 01:01
RCHowell pushed a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants