Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Func resolver #1378

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Func resolver #1378

merged 1 commit into from
Feb 26, 2024

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Feb 24, 2024

Relevant Issues

  • [Closes/Related To] Issue #XXX

Description

  • Changed Function Match logic.

    • Previously we assumed that if all the args require coercion to match the function signature, then the function match should failed, as there should be another function signature that requires no coercion. Such transitive coercion model is not correct.
    • Change the matching logic to gather all possible candidate, then sort them first based on number of coercion and then the function Precedence.
  • Also, added the constrained decimal as a valid numeric type when generating function signature.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • Yes.
  • Any backward-incompatible changes? [YES/NO]

    • No API changes.
  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
    • No.
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes.

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Feb 24, 2024

Conformance comparison report

Base (c3b6e66) ae29916 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (c3b6e66) but now fail: 0

Number failing in Base (c3b6e66) but now pass: 0

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (c3b6e66) to head (57e41b1).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1378   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity     2095     2095           
=========================================
  Files           221      221           
  Lines         15984    15984           
  Branches       2896     2896           
=========================================
  Hits          11534    11534           
  Misses         3641     3641           
  Partials        809      809           
Flag Coverage Δ
CLI 11.86% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yliuuuu yliuuuu marked this pull request as ready for review February 24, 2024 01:44
@yliuuuu yliuuuu merged commit 5121093 into main Feb 26, 2024
10 checks passed
@yliuuuu yliuuuu deleted the func-resolver branch February 26, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants