Flatten case when branch result type in PlanTyper #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (5e9cd19) but now fail: 0 Number failing in Base (5e9cd19) but now pass: 0 |
alancai98
commented
Feb 10, 2024
| @@ -796,7 +796,7 @@ internal class PlanTyper( | |||
| } | |||
|
|
|||
| // Replace the result's type | |||
| val type = AnyOfType(ref.type.allTypes.filterIsInstance<StructType>().toSet()) | |||
| val type = AnyOfType(ref.type.allTypes.filterIsInstance<StructType>().toSet()).flatten() | |||
There was a problem hiding this comment.
In the other branch (L767-785), there is a .flatten() call on L782, but there is no .flatten() call within this branch.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
============================================
- Coverage 80.76% 72.15% -8.61%
- Complexity 2064 2095 +31
============================================
Files 191 221 +30
Lines 13987 15984 +1997
Branches 2651 2896 +245
============================================
+ Hits 11297 11534 +237
- Misses 1903 3641 +1738
- Partials 787 809 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RCHowell
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typing of a
CASE WHENbranch does not flatten the type in certain circumstances. Noticed this when I calledSELECT <table>.<struct>.* FROM <table>and the an argument of theTUPLEUNIONwas anAnyOfTypecontaining a singleSTRUCT.Other Information
Updated Unreleased Section in CHANGELOG: [Yes]
Any backward-incompatible changes? [NO]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.