Fix SqlDialect's defaultReturn return type to be SqlBlock
#1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (3e28dd5) but now fail: 0 Number failing in Base (3e28dd5) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1357 +/- ##
=========================================
Coverage 72.15% 72.15%
Complexity 2095 2095
=========================================
Files 221 221
Lines 15984 15984
Branches 2896 2896
=========================================
Hits 11534 11534
Misses 3641 3641
Partials 809 809
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alancai98
commented
Jan 31, 2024
rchowell
suggested changes
Jan 31, 2024
rchowell
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
SqlDialect'sdefaultReturnfunction wasNothingrather thanSqlBlock. This led the functions directly returningdefaultReturn(e.g.visitTypeCustom) to have an output type ofNothingrather thanSqlBlock.Other Information
Updated Unreleased Section in CHANGELOG: [YES]
Any backward-incompatible changes? [NO]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.