Adds support for Sprout-generated equality/hashCode #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds default and methods to each product Previous generation resulted in interfaces
Conformance comparison report
Number passing in both: 5372 Number failing in both: 446 Number passing in Base (eb0b72e) but now fail: 0 Number failing in Base (eb0b72e) but now pass: 0 |
RCHowell
requested changes
Aug 22, 2023
Comment on lines
+199
to
+201
| this.props.forEach { prop -> | ||
| body.addStatement("if (%N != other.%N) return false", prop.name, prop.name) | ||
| } |
There was a problem hiding this comment.
I think we should deeply compare collections as well
There was a problem hiding this comment.
This should be deeply comparing as-is. I just pushed tests to show some examples. Thanks!
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
=========================================
Coverage 71.55% 71.55%
Complexity 2323 2323
=========================================
Files 224 224
Lines 17097 17097
Branches 3189 3189
=========================================
Hits 12233 12233
Misses 3881 3881
Partials 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RCHowell
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
:test/sprout-testssubproject to run integration tests on generated codeOther Information
and Code Style Guidelines? NO
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.