Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix / improve loading state #144

Merged
merged 7 commits into from
Jul 19, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/client/actions/ParticipantActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function getParticipantActions(alt, participantResource, errorActions) {
} else {
this.participantListUpdated(participantList);
}
}, err => errorActions.error(err, 'Osallitujia ei voitu ladata'));
}, err => errorActions.error(err, 'Osallistujia ei voitu ladata'));
};
}

Expand All @@ -61,9 +61,12 @@ export function getParticipantActions(alt, participantResource, errorActions) {
}

updateParticipantPresences(ids, newValue, offset, limit, order, filter) {
participantResource.raw('post', 'massAssign', { body: { ids: ids, newValue: newValue, fieldName: 'presence' } })
.then(response => this.loadParticipantList(offset, limit, order, filter),
err => errorActions.error(err, 'Osallistujien tilan päivitys epäonnistui'));
return dispatch => {
dispatch();
participantResource.raw('post', 'massAssign', { body: { ids: ids, newValue: newValue, fieldName: 'presence' } })
.then(response => this.loadParticipantList(offset, limit, order, filter),
err => errorActions.error(err, 'Osallistujien tilan päivitys epäonnistui'));
};
}

updateProperty(participantId, property, value) {
Expand Down
25 changes: 20 additions & 5 deletions src/client/components/ParticipantListPage/ParticipantListPage.jsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import React from 'react';
import _ from 'lodash';
import { Table, Grid, Row, Col, Input, Button } from 'react-bootstrap';
import { Table, Grid, Row, Col, Input } from 'react-bootstrap';
import { getParticipantListUpdater } from './containers/ParticipantListUpdater';
import { getSortableHeaderCellContainer } from './containers/SortableHeaderCellContainer';
import { getListOffsetSelectorContainer } from './containers/ListOffsetSelectorContainer';
import { getParticipantRowsContainer } from './containers/ParticipantRowsContainer';
import { getQuickFilterContainer } from './containers/QuickFilterContainer';
import { getParticipantCount } from './containers/ParticipantCount';
import { getPresenceLabel } from '../../components';
import { LoadingButton } from '../../components';

function getOrder(query) {
try {
Expand Down Expand Up @@ -35,22 +36,36 @@ function getLimit(query) {
return query.limit && Number(query.limit) || 200;
}

export function getMassEdit() {
export function getMassEdit(participantStore) {
class MassEdit extends React.Component {
constructor(props){
super(props);
this.state = {};
this.state = { loading: false };
this.onSubmit = this.onSubmit.bind(this);
this.onChange = this.onChange.bind(this);
this.onStoreChanged = this.onStoreChanged.bind(this);
}

onSubmit(event) {
event.preventDefault();
if (this.state.value !== null && this.state.value !== 'null') {
this.setState({ value: this.state.value, loading: true });
this.props.onSubmit(this.state.value);
}
}

componentDidMount() {
participantStore.listen(this.onStoreChanged);
}

componentWillUnmount() {
participantStore.unlisten(this.onStoreChanged);
}

onStoreChanged() {
this.setState({ loading: false });
}

onChange(event){
event.persist();
this.setState({ value: event.target.value });
Expand All @@ -69,7 +84,7 @@ export function getMassEdit() {
<option value="2">{ tmpOutCampLabel }</option>
<option value="3">{ outCampLabel }</option>
</Input>
<Button type="submit" bsStyle="primary" disabled={ (this.props.count > 0 ? false : true) }>Tallenna</Button>
<LoadingButton loading={ this.state.loading } bsStyle="primary" label="Tallenna" labelWhileLoading="Tallennetaan…"/>
</form>
);
}
Expand Down Expand Up @@ -118,7 +133,7 @@ export function getParticipantListPage(participantStore, participantActions, sea
const ParticipantRowsContainer = getParticipantRowsContainer(participantStore);
const QuickFilterContainer = getQuickFilterContainer(participantStore, participantActions, searchFilterActions, searchFilterStore);
const ParticipantCount = getParticipantCount(participantStore);
const MassEdit = getMassEdit();
const MassEdit = getMassEdit(participantStore);
const SelectAll = getSelectAll();

class ParticipantListPage extends React.Component {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function getParticipantRowsContainer(participantStore) {

const rowCreator = element => <ParticipantRow key={ element.participantId } isChecked={ isChecked } checkboxCallback={ checkboxCallback } availableDates={ availableDates } participant={ element } />;

return this.state.participants === undefined
return this.state.loading
? (
<tbody>
<tr>
Expand Down
22 changes: 22 additions & 0 deletions src/client/components/Util/LoadingButton.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import React from 'react';
import { Button } from 'react-bootstrap';

export class LoadingButton extends React.Component {
render() {
return (
<Button
type="submit"
disabled={ this.props.loading }
bsStyle={ this.props.bsStyle }>
{ this.props.loading ? this.props.labelWhileLoading : this.props.label }
</Button>
);
}
}

LoadingButton.propTypes = {
loading: React.PropTypes.bool.isRequired,
label: React.PropTypes.string.isRequired,
labelWhileLoading: React.PropTypes.string.isRequired,
bsStyle: React.PropTypes.string,
};
1 change: 1 addition & 0 deletions src/client/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ export { PresenceHistory } from './ParticipantDetailsPage/PresenceHistory';
export { ParticipantDates } from './ParticipantDetailsPage/ParticipantDates';
export { getLogin } from './OfflineLogin';
export { PropertyTextArea } from './PropertyTextArea';
export { LoadingButton } from './Util/LoadingButton';
3 changes: 2 additions & 1 deletion src/client/stores/ParticipantStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,14 @@ export function getParticipantStore(alt, ParticipantActions, RegistryUserActions
}

handleLoadParticipantList(countParticipants) {
this.participants = undefined;
this.loading = true;
if (countParticipants) {
this.participantCount = undefined;
}
}

handleParticipantListUpdated({ participants, newCount }) {
this.loading = false;
this.participants = participants;
if (newCount !== undefined) {
this.participantCount = newCount;
Expand Down
9 changes: 9 additions & 0 deletions src/client/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ $screen-sm: 768px;
@import "~bootstrap-sass/assets/stylesheets/_bootstrap.scss";
@import "~react-spinner/react-spinner.css";

table .react-spinner, .h2 .react-spinner {
top: 15px;
left: 15px;
}

.react-spinner_bar {
background: $mid-grey;
}

/**
* Tables
*/
Expand Down