Add generic filter that allows user to choose which property is filtered #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/client/components/ParticipantListPage/containers/QuickFilterContainer.jsx
| export function getGenericPropertyFilterContainer(searchFilterStore, searchFilterActions) { | ||
| const PropertyFilterContainer = getPropertyFilterContainer(searchFilterStore, searchFilterActions); | ||
|
|
||
| const properties = [ |
There was a problem hiding this comment.
Onko joku syy miksei tää oo vain objekti, kun nää on nimi-arvopareja?
There was a problem hiding this comment.
Koska sekä nimeä että arvoa käytetään? Voishan ne muuttaa objekteiksi, mutta ei se mun mielestä helpota mitään...
There was a problem hiding this comment.
Se ois ehkä snadisti tyylikkäämpää mun mielestä, nää arrayt joissa on array sisällä on mun mielestä vähemmän dokumentoivia. Tämmönen rakenne on perusteltu sillon kun halutaan tietty järjestys, jos se on tarkoitus niin sitä tää on tosi hyvä näin :)
|
|
||
| } | ||
|
|
||
| onValueChange(e) { |
|
Muutama pikkusäätö, muutoin 5/5 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.