Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.3 #55

Merged
merged 12 commits into from
Dec 2, 2024
Merged

Python 3.3 #55

merged 12 commits into from
Dec 2, 2024

Conversation

ilesoft
Copy link
Contributor

@ilesoft ilesoft commented Oct 28, 2024

No description provided.

@ilesoft ilesoft force-pushed the python3-3 branch 2 times, most recently from 48f738d to 3daeb32 Compare October 28, 2024 12:48
Base automatically changed from django-1_6 to develop November 11, 2024 09:56
@ilesoft ilesoft marked this pull request as ready for review November 18, 2024 10:27
@ilesoft ilesoft requested review from villevuor and ZeiP November 18, 2024 12:35
@ilesoft ilesoft marked this pull request as draft November 18, 2024 13:24
This will ease migration to Python 3.
Kipa is not ran as a script.
This removes rest of carriage returns from python and template files.

Also removes trailing spaces which weren't removed in
54c1c73 because of carriage
returns was not taken in account.
Also remove imports with *
__div__ doesn't exists in python 3.
To see more, read PEP 3120.
@ilesoft ilesoft marked this pull request as ready for review November 19, 2024 12:49
@ilesoft
Copy link
Contributor Author

ilesoft commented Nov 22, 2024

Tajusin juuri että tuo PostDataRecorder ei tullut päivitetyksi Python3-yhteensopivaksi. Se on kuitenkin poistettu viimeksi käytöstä commitissa 4e103c1. Se voidaan varmaan heittää /dev/null:iin jossain kohtaa.

Copy link
Contributor

@pholm pholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ajoin yleisiä keissejä käsin kliksutellen sekä testit. Jätin muutamia kommentteja devausympäristöön liittyen, mutta näitä voitanee fiksailla myös toisissa pullareissa.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ilesoft ilesoft merged commit b2a4118 into develop Dec 2, 2024
3 checks passed
@ilesoft ilesoft deleted the python3-3 branch December 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants