Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format python #50

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Format python #50

merged 4 commits into from
Oct 23, 2024

Conversation

ilesoft
Copy link
Contributor

@ilesoft ilesoft commented Oct 18, 2024

Tähän pitää vielä laittaa tuon formatointi-commitin lisäys tuonne .git-blame-ignore-revs:iin, mutta se kannattaa tehdä vasta kun saadaan rebasettua tämä developin päälle. Tehty

@ilesoft ilesoft force-pushed the format-python branch 2 times, most recently from 33fd2fd to 3eb5e9c Compare October 18, 2024 10:15
Base automatically changed from refactor-templates to develop October 23, 2024 05:21
Formatting is done with black version 21.12.b0, because it was
the last black version supporting python2 code.

It is installed with
`pip install 'black[python2]==21.12b0'`
and
`pip install --upgrade click==8.0.2`.
Later is needed because of know incompliance
between black 21 and newer click version.

Also *.py.example files are formatted.
@ilesoft ilesoft marked this pull request as ready for review October 23, 2024 07:10
@ilesoft ilesoft requested a review from ZeiP October 23, 2024 07:10
@ilesoft
Copy link
Contributor Author

ilesoft commented Oct 23, 2024

Katselmointia @vaaralav?

README.md Outdated Show resolved Hide resolved
@vaaralav
Copy link
Member

Black 21.12.b0 versio valikoitui ilmeisesti koska se on tuorein versio Python 2:lle?

@ilesoft ilesoft merged commit a29094e into develop Oct 23, 2024
3 checks passed
@ilesoft ilesoft deleted the format-python branch October 23, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants