Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic product firmware versioning #8

Merged
merged 22 commits into from
Apr 12, 2023
Merged

Conversation

laupow
Copy link
Collaborator

@laupow laupow commented Apr 11, 2023

Story: https://app.shortcut.com/particle/story/117506

This PR adds an auto-versioning feature is designed to manage product firmware version numbers in an automated and consistent manner.

See README.md and AUTO_VERSION.md for usage documentation and example workflows.

There's a new CI test in .github/workflows/test.yml that exercises the feature.

@laupow laupow requested review from wraithan and hugomontero April 11, 2023 18:01
Copy link

@wraithan wraithan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the AUTO_VERSION.md you start with what looks like a very complex example with lots of inline shell scripting stuff. I think it might be helpful to reframe the document to build up from manual -> semi -> continuous.

I expect semi to be the most common type, especially if we can show an example of driving it by new git tag (possibly just on main) without all the shell scripting in the user's action that continuous has, so it feels "clean".

@laupow laupow merged commit 2816137 into main Apr 12, 2023
@laupow laupow deleted the feature/auto-version branch April 12, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants