-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [sc-117417] Add semver support and device-os-output variable #7
Conversation
Latest would be good to have, but I wanted latest LTS if it is available. What about enabling something like this tilde range syntax then we can just say |
@wraithan The PR now adds support for semver device-os-version inputs. How do the usage docs look for your use-case? Tilde versions are supported but not documented. Lines 20 to 28 in 0f36975
|
Carrot ranges are good too, they're default in npm for a reason. Works for me, looks like the build fails when The note about production is also interesting, our users do not use our platform that way, they definitely hardcode a version and leave it forever in most cases, which they can do by omiting the carrot so it's fine. Upgrades within a major, especially if the device has kept up on OS versions will (on 2.x+) be combined OTA as well as having incremental. So in many cases can skip safe mode so it feels like it'd be fine to suggest using a semver range in production, but the more risk adverse or those burned by safe mode healer + bad connectivity in the past will almost certainly hardcode an OS version. |
I appreciate how well tested all this code is, I was able to scroll through the tests and see how things would react, very nice. |
Story details: https://app.shortcut.com/particle/story/117417
Adds
device-os-version
output. When users pass a semver orlatest
as thedevice-os-version
input, it may be useful to know which Device OS version the firmware was compiled against.