Fix: Footer Count Error #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e range for footer count
balaji-jr
suggested changes
Aug 19, 2024
balaji-jr
suggested changes
Aug 19, 2024
balaji-jr
suggested changes
Aug 19, 2024
balaji-jr
reviewed
Aug 19, 2024
balaji-jr
reviewed
Aug 19, 2024
balaji-jr
reviewed
Aug 19, 2024
balaji-jr
reviewed
Aug 19, 2024
balaji-jr
suggested changes
Aug 19, 2024
balaji-jr
reviewed
Aug 19, 2024
src/hooks/useQueryResult.tsx
Outdated
| { | ||
| onSuccess: (data: CountResponse) => { | ||
| const count = _.first(data)?.count; | ||
| count !== undefined && setLogsStore((store) => setTotalCount(store, count)); |
There was a problem hiding this comment.
What happens when null ?
Appropriate check here would be setting the count only if its a number.
balaji-jr
reviewed
Aug 19, 2024
src/hooks/useQueryResult.tsx
Outdated
| refetch: refetchCount, | ||
| } = useQuery( | ||
| ['fetchCount', logsQuery], | ||
| async () => { |
There was a problem hiding this comment.
refer https://github.com/parseablehq/console/blob/main/src/hooks/useGetStreamInfo.tsx to get an idea about existing practice
balaji-jr
suggested changes
Aug 19, 2024
balaji-jr
approved these changes
Aug 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix the bug where queries are not fired on change of time range for footer count.