Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-176 - conditionally hide live tail for https protocol #177

Merged
merged 1 commit into from
Jan 17, 2024
Merged

ISSUE-176 - conditionally hide live tail for https protocol #177

merged 1 commit into from
Jan 17, 2024

Conversation

balaji-jr
Copy link
Contributor

@balaji-jr balaji-jr self-assigned this Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nitisht
Copy link
Member

nitisht commented Jan 17, 2024

@balaji-jr can you sign the CLA by adding the comment.

@balaji-jr
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@balaji-jr
Copy link
Contributor Author

recheck

nitisht
nitisht approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Tested

nikhilsinhaparseable
nikhilsinhaparseable approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the livetail on http, looks good

@nativ-labs
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@nativ-labs
Copy link
Contributor

recheck

nitisht added a commit to parseablehq/.github that referenced this pull request Jan 17, 2024
@nitisht
@nativ-labs has signed the CLA in parseablehq/console#177
983a1c5
@nitisht nitisht merged commit e87fee2 into parseablehq:main Jan 17, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

@nitisht nitisht nitisht approved these changes

Assignees

@balaji-jr balaji-jr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balaji-jr @nitisht @nativ-labs @nikhilsinhaparseable