Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Security upgrade semver from 7.5.1 to 7.5.2 #8704

Merged
merged 3 commits into from
Jul 30, 2023
Merged

fix: Security upgrade semver from 7.5.1 to 7.5.2 #8704

merged 3 commits into from
Jul 30, 2023

Conversation

m12331
Copy link

@m12331 m12331 commented Jul 28, 2023

Pull Request

Issue

Closes: #8651

Approach

Bumps semver from 7.5.1 to 7.5.2

nvm nvm use 16
-> Now using node v16.15.0 (npm v8.5.5)

npm i -E [email protected]

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@mtrezza
Copy link
Member

mtrezza commented Jul 28, 2023 •
edited
Loading

This is Parse Server 5, so we need to run this with Node 12.x, not Node 16.x, sorry I was thinking about Parse Server 6. Could you revert all the changes (i.e. restore the original files) and then run again npm i -E [email protected]?

mtrezza
mtrezza approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a036071) 94.12% compared to head (77f3cd9) 94.12%.
Report is 4 commits behind head on release-5.x.x.

❗ Current head 77f3cd9 differs from pull request most recent head a8ade89. Consider uploading reports for the commit a8ade89 to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##           release-5.x.x    #8704   +/-   ##
==============================================
  Coverage          94.12%   94.12%           
==============================================
  Files                183      183           
  Lines              13798    13803    +5     
==============================================
+ Hits               12987    12992    +5     
  Misses               811      811
Files Changed Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/Controllers/DatabaseController.js 93.96% <100.00%> (+0.05%) ⬆️
src/RestWrite.js 94.61% <100.00%> (-0.04%) ⬇️
src/Routers/FilesRouter.js 93.25% <100.00%> (-0.05%) ⬇️
src/Utils.js 98.13% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title refactor: Bumps semver from 7.5.1 to 7.5.2 fix: Security upgrade semver from 7.5.1 to 7.5.2 Jul 30, 2023
@mtrezza mtrezza merged commit c7fa3b9 into parse-community:release-5.x.x Jul 30, 2023
parseplatformorg pushed a commit that referenced this pull request Jul 30, 2023
@semantic-release-bot
chore(release): 5.5.4 [skip ci]
62bb396 
## [5.5.4](5.5.3...5.5.4) (2023-07-30)

### Bug Fixes

* Security upgrade semver from 7.5.1 to 7.5.2 ([#8704](#8704)) ([c7fa3b9](c7fa3b9))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.5.4

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released-5.x.x Released as LTS version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m12331 @mtrezza @parseplatformorg