-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade parse from 3.4.2 to 4.0.1 #8570
Conversation
Snyk has created this PR to upgrade parse from 3.4.2 to 4.0.1. See this package in npm: https://www.npmjs.com/package/parse See this project in Snyk: https://app.snyk.io/org/acinader/project/dfeefcca-4b71-49d5-96c8-6e4203f29ab8?utm_source=github&utm_medium=referral&page=upgrade-pr
Thanks for opening this pull request! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-5.x.x #8570 +/- ##
=================================================
- Coverage 94.12% 84.42% -9.70%
=================================================
Files 183 183
Lines 13798 13808 +10
=================================================
- Hits 12987 11658 -1329
- Misses 811 2150 +1339
☔ View full report in Codecov by Sentry. |
I don't think we can even merge this into Parse Server 5. The SDK makes a major version jump, so this would be a breaking change. |
I attempted to write the subscription code in so that it would be backwards compatible, but I think the minimum node change means that this PR can't be merged |
Yes, too bad, but this can always happen, unless we also maintain a LTS version for Parse JS SDK. Once we have a mono-repo that contain both server and sdk it may be easier to do that. |
Pull Request
Issue
Closes: #8554
Approach
Tasks