Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade path-to-regexp from 0.1.7 to 6.2.1 #8558

Merged
merged 4 commits into from
May 22, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented May 22, 2023

Pull Request

Issue

Closes: #8546

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.36 🎉

Comparison is base (00c362d) 93.97% compared to head (b00b2d8) 94.33%.

❗ Current head b00b2d8 differs from pull request most recent head b488412. Consider uploading reports for the commit b488412 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8558      +/-   ##
==========================================
+ Coverage   93.97%   94.33%   +0.36%     
==========================================
  Files         183      183              
  Lines       14572    14575       +3     
==========================================
+ Hits        13694    13750      +56     
+ Misses        878      825      -53     
Impacted Files Coverage Δ
src/cloud-code/Parse.Cloud.js 99.29% <100.00%> (ø)
src/middlewares.js 97.03% <100.00%> (+4.34%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy requested a review from a team May 22, 2023 05:16
@mtrezza mtrezza merged commit 4c1093e into parse-community:alpha May 22, 2023
@mtrezza mtrezza mentioned this pull request May 22, 2023
9 tasks
@dblythy dblythy deleted the path-to-regexp branch May 23, 2023 05:09
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.13

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 25, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants