Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add FS storage to docs #7681

Merged
merged 4 commits into from
Nov 8, 2021
Merged

docs: add FS storage to docs #7681

merged 4 commits into from
Nov 8, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 7, 2021

New Pull Request Checklist

Issue Description

Readme is missing FS adapter even though link to full docs has details about the FS adapter.

Related issue: #6768 and parse-community/docs#780

Approach

Add the FS adapter to the README and clean up this section to match the rest of the document.

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 7, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #7681 (70c4b76) into alpha (31960b5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha    #7681      +/-   ##
==========================================
- Coverage   93.89%   93.88%   -0.01%     
==========================================
  Files         183      183              
  Lines       13626    13626              
==========================================
- Hits        12794    12793       -1     
- Misses        832      833       +1     
Impacted Files Coverage Δ
src/RestWrite.js 94.04% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31960b5...70c4b76. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is this ready for merge?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 8, 2021

Yup, it’s ready

@mtrezza mtrezza merged commit 611bd9b into parse-community:alpha Nov 8, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.6

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 10, 2021
@cbaker6 cbaker6 deleted the patch-3 branch November 22, 2021 18:42
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.10

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 15, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants