-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: allow ES import for cloud string if package type is module #7560
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #7560 +/- ##
=======================================
Coverage 93.94% 93.95%
=======================================
Files 181 181
Lines 13279 13281 +2
=======================================
+ Hits 12475 12478 +3
+ Misses 804 803 -1
Continue to review full report at Codecov.
|
Could you resolve this conflict? Sorry, this will go away with release automation, hopefully by this month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This change has been released in version 5.0.0-beta.1 |
So as discussed with @mtrezza , here @dblythy we have an issue, Last months and also with #7525 we have evidence that the Parse server start up should be refactored with a clean async start function. Then we can drop the old constructor pattern (not flexible at all since we cannot return a promise) For now the PR could introduce huge problem in a prod environment. i'll recommend to revert this PR. I'll open an additional Issue with a first suggestion of the spec for the Parse Server start async fn. And also a suggestion of feature implementation to avoid a breaking change with a support of both |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Currently, if package type is module, specifying a cloud string does not work.
Related issue: #7559
Approach
Checks env variable
npm_package_type
, which is autoset, and if it's amodule
, usesimport()
instead ofrequire()
TODOs before merging