Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace hardcoded error codes with references #7546

Merged
merged 10 commits into from
Oct 18, 2021

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 4, 2021

New Pull Request Checklist

Issue Description

Hardcoded errors should not exist in Parse Server.

Related issue: #7545

Approach

Removes some hard coded error codes in preference for Parse.Error

TODOs before merging

  • Add entry to changelog (is this necessary?)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 4, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #7546 (b822922) into master (b5fc0d5) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7546      +/-   ##
==========================================
- Coverage   93.97%   93.63%   -0.34%     
==========================================
  Files         181      181              
  Lines       13354    13354              
==========================================
- Hits        12549    12504      -45     
- Misses        805      850      +45     
Impacted Files Coverage Δ
src/AccountLockout.js 97.56% <ø> (ø)
src/LiveQuery/ParseLiveQueryServer.js 95.68% <100.00%> (ø)
src/Adapters/Cache/RedisCacheAdapter.js 12.28% <0.00%> (-75.44%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.47% <0.00%> (-0.22%) ⬇️
src/RestWrite.js 93.88% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fc0d5...b822922. Read the comment docs.

@dblythy dblythy requested a review from a team October 16, 2021 04:08
CHANGELOG.md Outdated Show resolved Hide resolved
doesn't need a changelog entry, as this is merely a refactor
@mtrezza mtrezza changed the title Remove some hardcoded error codes refactor: replace hardcoded error codes with references Oct 18, 2021
@mtrezza mtrezza merged commit 12eb6c8 into parse-community:master Oct 18, 2021
@mtrezza mtrezza mentioned this pull request Oct 18, 2021
3 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 27, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants