Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node.js 15.13.0 in CI #7312

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Conversation

olleolleolle
Copy link
Contributor

New Pull Request Checklist

Issue Description

This fixes a warning in the CI Self-Check

❌ CI environment 'Node 15' uses an old Node.js minor version 15.12.0 instead of 15.13.0.
❌ CI does not have environments using the following versions of Node.js: 15.13.0.
Error: CI environments are not up-to-date with the latest Node.js versions.

Approach

Followed an old update to the CI and imitated it.

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #7312 (879bdf0) into master (ba32dae) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 879bdf0 differs from pull request most recent head c0116b0. Consider uploading reports for the commit c0116b0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7312      +/-   ##
==========================================
- Coverage   93.92%   93.89%   -0.04%     
==========================================
  Files         181      181              
  Lines       13190    13190              
==========================================
- Hits        12389    12385       -4     
- Misses        801      805       +4     
Impacted Files Coverage Δ
src/Adapters/Auth/httpsRequest.js 95.23% <0.00%> (-4.77%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.59% <0.00%> (-0.66%) ⬇️
src/RestWrite.js 93.84% <0.00%> (-0.17%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 80.32% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba32dae...c0116b0. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mtrezza
Copy link
Member

mtrezza commented Apr 1, 2021

Can you please change the CI timeout from 15 to 20 to make the postgres check pass?

It's in the CI.yaml, check-postgres, timeout-minutes: 15

@olleolleolle
Copy link
Contributor Author

Can you please change the CI timeout from 15 to 20 to make the postgres check pass?

It's in the CI.yaml, check-postgres, timeout-minutes: 15

I made a commit, from my phone, did it come out right?

@mtrezza
Copy link
Member

mtrezza commented Apr 1, 2021

Yes, but could you try with 30mins? Not sure if it's just the test needing more time or a faulty test.

@dplewis
Copy link
Member

dplewis commented Apr 1, 2021

@mtrezza As I mentioned the flaky timeout tests (batch requests tests) will always be there until fixed via #7283

Feel free to ignore it until then as an increase in timeout to 30 minutes won't help and waist Github Action credits (I don't know if we have unlimited credits being open sourced).

@mtrezza
Copy link
Member

mtrezza commented Apr 1, 2021

@dplewis Does this only affect one Postgres test, or all Postgres tests?

@dplewis
Copy link
Member

dplewis commented Apr 1, 2021

Its flaky so random but 14/15 passing test suites is passing to me

@mtrezza
Copy link
Member

mtrezza commented Apr 1, 2021

Okay, so we'll set the timeout back to 15 and just re-run until it passes, I guess, thanks for clearing this up.

@olleolleolle Apologies for the confusion, would you please set this back to 15 and we'll just re-run. done

@mtrezza mtrezza mentioned this pull request Apr 2, 2021
7 tasks
@mtrezza mtrezza merged commit 626352d into parse-community:master Apr 2, 2021
@olleolleolle olleolleolle deleted the node-15-13 branch April 2, 2021 18:22
Arul- pushed a commit to Arul-/parse-server that referenced this pull request Apr 4, 2021
* Use Node.js 15.13.0 in CI

* CI: Allow check-postgres 20 timeout

* CI: 30 min timeout for check-postgres

* reverted postgres timeout to 15

Co-authored-by: Manuel <[email protected]>
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza mentioned this pull request Mar 12, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants