improve field deletion in collection #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6823 +/- ##
==========================================
- Coverage 93.87% 93.33% -0.54%
==========================================
Files 169 169
Lines 12206 12209 +3
==========================================
- Hits 11458 11395 -63
- Misses 748 814 +66
Continue to review full report at Codecov.
|
dplewis
approved these changes
Jul 27, 2020
therealjmj
pushed a commit
to therealjmj/SC-parse-server
that referenced
this pull request
Aug 20, 2020
* added filter to updateMany when deleting field * added test cases * added changelog entry
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply adds a filter to
updateManywhen deleting the field from the collection. That means that only documents will be updated that contain the field.In the status quo (without index), this added filter has no effect. But it gives the devop the ability to manually add the required index for the field to be deleted. The index has to be
{ <fieldNameToDelete>: { $exists: true }}.Also added an additional test case for field deletion without index, which was missing before, hence increase in coverage.
closes #6815