Case insensitive username and email indexing and query planning for Postgres #6506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing error to see what happens...
Attempting to resolve postgres in CL by installing postgis via sudo instead of through apt/packages
Removed extra lines of postgres that were under "services" and "addons". I believe the "postgresql" line under "services" was installing the default of 9.6 and "addons" was installing postgres 11. My guess is the fail was occurring due to 9.6 being called sometimes and it never had postgis installed. If this is true, the solution is to only install one version of postgres, which is version 11 with postgis 2.5.
Adding test case for verifying indexing for caseInsensitive
…has a minimum requirement of postgis 2.2. Documented the change in the readme. This is address #6441
…Also switched postgis image it points to as the other one hasn't been updated in over a year.
…contributions. The official image automatically creates a user named 'postgres', but it does require a password, which the command sets to 'postgres'
…will always take a few seconds because the db is installing from scratch everytime. If postgres/postgis images aren't already downloaded locally, it will take even longer. Worst case, if the command times out on first run. Stop and remove the parse-postgres container and run the command again, 20 seconds should be enough wait time then
Codecov Report
@@ Coverage Diff @@
## master #6506 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 169 169
Lines 11959 11959
=======================================
Hits 11229 11229
Misses 730 730 Continue to review full report at Codecov.
|
|
@cbaker6 Can you check the travis build? You need to run the linter. |
Adding test case for verifying indexing for caseInsensitive
…has a minimum requirement of postgis 2.2. Documented the change in the readme. This is address #6441
…Also switched postgis image it points to as the other one hasn't been updated in over a year.
…contributions. The official image automatically creates a user named 'postgres', but it does require a password, which the command sets to 'postgres'
…will always take a few seconds because the db is installing from scratch everytime. If postgres/postgis images aren't already downloaded locally, it will take even longer. Worst case, if the command times out on first run. Stop and remove the parse-postgres container and run the command again, 20 seconds should be enough wait time then
…(this can be bad when looking at a query plan for Insert, Delete, etc.) the query or to just setup the query plan (default, previous versions defaulted to 'analyze'). Alse added some comparsons on sequential vs index searches for postgres
…p time comparison between searches as this seemed to be variable
…an username and password. Also added explain to aggregate method
…as causing issues
cbaker6
commented
Mar 23, 2020
…s as 'beforeEach' already handles this
…gres (similar to old style). Note that the official postgres docker image for postgres requires POSTGRES_PASSWORD to be set in order to use the image
…version to be backwards compatibile with older versions of parse server
cbaker6
changed the title
I missed this comment, but yes I can run the postgres adapter tests locally. I couldn't run the whole spec locally because of the bugs in #6531. I run postgres via docker locally along with some remote servers I have deployed. Both fail, which led me to fixes in 6531. Now I can run locally and remotely |
|
@dplewis you ok with this? also want to see the tests pass as master is currently hanging on the postgres test. |
|
ok. tests look good.... |
|
@cbaker6 Since #6531 is merged can you resolve the conflicts? Also checkout #6531 (comment) |
dplewis
approved these changes
Apr 3, 2020
6 tasks
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial code, still needs to be fixed