-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLP objectId size validation fix #6332
CLP objectId size validation fix #6332
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6332 +/- ##
==========================================
+ Coverage 93.83% 94.01% +0.18%
==========================================
Files 169 169
Lines 11588 12139 +551
==========================================
+ Hits 10874 11413 +539
- Misses 714 726 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few nits from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. note the pre-existing spelling error
@@ -1665,7 +1665,7 @@ describe('Class Level Permissions for requiredAuth', () => { | |||
); | |||
}); | |||
|
|||
it('required auth test create/get/update/delete not authenitcated', done => { | |||
it('required auth test get not authenitcated', done => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'authenticated' search file as other places too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. LGTM!
* Relax regex for customId ; allow varying id length * test * remove trycatch, fix typo * de-duplicate test names; test pointer targetclass * fixed early return; detailed errors for protected
Fixes #6331