Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLP objectId size validation fix #6332

Merged
merged 5 commits into from
Jan 14, 2020
Merged

CLP objectId size validation fix #6332

merged 5 commits into from
Jan 14, 2020

Conversation

BufferUnderflower
Copy link
Contributor

Fixes #6331

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #6332 into master will increase coverage by 0.18%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6332      +/-   ##
==========================================
+ Coverage   93.83%   94.01%   +0.18%     
==========================================
  Files         169      169              
  Lines       11588    12139     +551     
==========================================
+ Hits        10874    11413     +539     
- Misses        714      726      +12
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 96.34% <97.36%> (-0.08%) ⬇️
src/Controllers/DatabaseController.js 94.39% <0%> (-0.63%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.12% <0%> (-0.32%) ⬇️
src/RestWrite.js 93.62% <0%> (ø) ⬆️
src/Routers/AggregateRouter.js 100% <0%> (ø) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.09% <0%> (+0.08%) ⬆️
src/triggers.js 94.85% <0%> (+0.38%) ⬆️
src/Routers/ClassesRouter.js 97.41% <0%> (+0.71%) ⬆️
src/RestQuery.js 97.72% <0%> (+2.24%) ⬆️
src/Adapters/Storage/Mongo/MongoCollection.js 100% <0%> (+2.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c43a93...5a62097. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few nits from me.

src/Controllers/SchemaController.js Outdated Show resolved Hide resolved
spec/schemas.spec.js Outdated Show resolved Hide resolved
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. note the pre-existing spelling error

@@ -1665,7 +1665,7 @@ describe('Class Level Permissions for requiredAuth', () => {
);
});

it('required auth test create/get/update/delete not authenitcated', done => {
it('required auth test get not authenitcated', done => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'authenticated' search file as other places too.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. LGTM!

@davimacedo davimacedo merged commit 2d257e2 into parse-community:master Jan 14, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Relax regex for customId ; allow varying id length

* test

* remove trycatch, fix typo

* de-duplicate test names; test pointer targetclass

* fixed early return; detailed errors for protected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ID length is hardcoded (10 chars) for CLP validation
4 participants