Implement WebSocketServer Adapter #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplewis
changed the title
|
I was supposing that the tests have passed. I've just noticed there are still some failing tests. Let me know if you need any help. |
|
@davimacedo Can you give it another look? |
Codecov Report
@@ Coverage Diff @@
## master #5866 +/- ##
===========================================
+ Coverage 83.12% 93.67% +10.54%
===========================================
Files 151 153 +2
Lines 10621 10636 +15
===========================================
+ Hits 8829 9963 +1134
+ Misses 1792 673 -1119
Continue to review full report at Codecov.
|
Merged
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Implement WebSocketServerAdapter * lint * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to implement their own WebSocketServer to use with Live Query Server.
Good for handling issues such as performance, dealing with faulty connections, handling authentication and authorization, or scalability.
I've added an interface for WSS Adapters. Let me know if anything should be changed or questions
I also created a gist of another WSSAdapter the uses uWebSocket.js.