Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL support via cli #5697

Merged
merged 5 commits into from
Jun 25, 2019

Conversation

davimacedo
Copy link
Member

GraphQL and Playground can now be launched using the CLI.

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #5697 into master will decrease coverage by 0.37%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5697      +/-   ##
==========================================
- Coverage   94.01%   93.63%   -0.38%     
==========================================
  Files         143      145       +2     
  Lines       10094    10187      +93     
==========================================
+ Hits         9490     9539      +49     
- Misses        604      648      +44
Impacted Files Coverage Δ
src/Options/index.js 100% <ø> (ø) ⬆️
src/GraphQL/ParseGraphQLServer.js 97.14% <ø> (ø) ⬆️
src/Options/Definitions.js 100% <ø> (ø) ⬆️
src/ParseServer.js 97.98% <100%> (+0.09%) ⬆️
src/cli/parse-server.js 32.81% <83.33%> (ø)
src/cli/utils/runner.js 86.36% <0%> (ø)
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.9% <0%> (+0.08%) ⬆️
src/RestWrite.js 93.32% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8a420...b28fb14. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Jun 20, 2019

You can generate the CLI definitions

@davimacedo davimacedo force-pushed the graphQLSupportViaCLI branch from ae3f43c to 7bad5e7 Compare June 21, 2019 00:07
@davimacedo
Copy link
Member Author

Thanks for guiding me on this @dplewis . I've just updated the PR. I also included basic instructions in the repository README file about how to run/use the GraphQL API. Could you have a try on this?

@davimacedo
Copy link
Member Author

I also created this project (https://github.com/parse-community/parse-server/projects/5) with the next priorities I have in mind.

@TomWFox
Copy link
Contributor

TomWFox commented Jun 24, 2019

@davimacedo I appreciate if you don’t feel it’s ready yet, but when you do could you please add a section in the Parse Server guide (docs repo) about GraphQL.

@davimacedo
Copy link
Member Author

@TomWFox I am working on this right now:
https://github.com/back4app/parsedocs/tree/graphql

@davimacedo
Copy link
Member Author

I am actually creating a new guide: /graphql/guide/

What do you think?

@TomWFox
Copy link
Contributor

TomWFox commented Jun 24, 2019

@davimacedo I can see the sense in that as Cloud Code is a separate guide, although it does seem a bit weird considering the GraphQL api is/will be included in the Parse Server API Reference.

Maybe you should open an issue/pr on the docs repo so we can add more thoughts there.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tried it and it works.

@davimacedo davimacedo merged commit 5bc79cc into parse-community:master Jun 25, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Including GraphQL options in CLI - now it was auto-generated

* Improving the way that the headers are passed to the playground

* Including README notes about GraphQL

* Improving final text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants