-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IGNORE] Fixing CI Issue, Add Indexes to Schema API #4322
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4322 +/- ##
==========================================
+ Coverage 92.52% 92.62% +0.09%
==========================================
Files 118 118
Lines 8256 8374 +118
==========================================
+ Hits 7639 7756 +117
- Misses 617 618 +1
Continue to review full report at Codecov.
|
2098348
to
8ee6e44
Compare
Resolved issue. Found to be an uncaught error being returned when attempting to auto-update the schema with indexes on startup, particularly with default classes Nothing definitively indicates why this only showed up in the CI, but I believe it had to do with some degree of timing. Adjusting local tests so that the auto-addition of indexes was done a bit later caused this error to show up in numerous places locally. |
There is a CI issue with #4240 that does not appear to manifest locally. I've created this PR to attempt to isolate the issue in the CI specifically. I also cleaned up the commit history.
This is just to diagnose and identify the issue, once it has been identified I'll close this back out.