Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase authentication provider is implemented #3174

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
"commander": "2.9.0",
"deepcopy": "0.6.3",
"express": "4.14.0",
"firebase-admin": "^4.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we want to depend on that module for every single user.

You can probably provide that module externally.

Copy link
Author

@mockitor mockitor Dec 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll try to provide externally. thanks for your feedback.

"intersect": "1.0.1",
"jsonwebtoken": "7.2.0",
"lodash": "4.17.2",
"lru-cache": "4.0.2",
"mime": "1.3.4",
Expand Down
53 changes: 53 additions & 0 deletions src/authDataManager/firebase.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Firebase authentication provider
var https = require('https');
var jwt = require("jsonwebtoken");

// Returns a promise that fulfills iff this user id is valid.
function validateAuthData(authData) {
return request().then(function (response) {
var publicKey = response[Object.keys(response)[0]]
try {
var decodedToken = jwt.verify(authData.access_token, publicKey);
console.log(authData)

if (decodedToken == null || decodedToken.id == null || decodedToken.id == "") {
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'Google auth is invalid for this user.');
}
resolve(decodedToken);
} catch (error) {
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, "Token validation error");
}

throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'Google auth is invalid for this user.');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

});
}

// A promisey wrapper for api requests
function request() {
return new Promise(function (resolve, reject) {
var googlePublicKeyUrl = "https://www.googleapis.com/robot/v1/metadata/x509/[email protected]";
https.get(googlePublicKeyUrl, function (res) {
var data = '';
res.on('data', function (chunk) {
data += chunk;
});
res.on('end', function () {
data = JSON.parse(data);
resolve(data);
});
}).on('error', function () {
reject('Failed to validate this access token with Google.');
});
});
}

// Returns a promise that fulfills if this app id is valid.
function validateAppId() {
return Promise.resolve();
}

module.exports = {
validateAppId,
validateAuthData
};
4 changes: 3 additions & 1 deletion src/authDataManager/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ let vkontakte = require("./vkontakte");
let qq = require("./qq");
let wechat = require("./wechat");
let weibo = require("./weibo");
let firebase = require("./firebase");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

let anonymous = {
validateAuthData: () => {
Expand All @@ -39,7 +40,8 @@ let providers = {
vkontakte,
qq,
wechat,
weibo
weibo,
firebase
}

module.exports = function(oauthOptions = {}, enableAnonymousUsers = true) {
Expand Down