Proposal for tracking Pushes #2917
Conversation
|
@alexblack updated the pull request - view changes |
|
The code is not building. |
| pushStatus.setRunning(response.results); | ||
| return this.sendToAdapter(body, response.results, pushStatus, config); | ||
| }).then((results) => { | ||
| return pushStatus.complete(results); | ||
| return pushStatus.complete(results).then(() => { | ||
| return updateTracking(response.results, results, pushStatus); |
There was a problem hiding this comment.
Response don't exist here...
There was a problem hiding this comment.
Agreed. It'd need to be refactored.
Correct. It also doesn't do anything yet.
Could you use this as an opportunity for me to learn a bit about parse-server? I'm not familiar with the push controller or StatusHandler, or how to know why the code belongs in once place or another. Could you point out where these two calls might go then? That'd help me a lot, thx. |
|
Like I said, those two call should go into that module: https://github.com/ParsePlatform/parse-server/blob/master/src/StatusHandler.js Inside the setRunning and complete methods |
|
@alexblack updated the pull request - view changes |
|
@alexblack updated the pull request - view changes |
|
Pushed some changes. Still incomplete, not anywhere close to being ready to be considered for merging. I'm very new to everything here - the codebase, the dependencies, the style, etc. So I imagine I'm doing everything wrong :) The code runs.
|
|
@alexblack updated the pull request - view changes |
|
@alexblack updated the pull request - view changes |
|
@alexblack updated the pull request - view changes |
|
As you mentioned is nowhere to be close to merge. I'm closing the PR. Reopen when ready. Also, make sure the test pass before reopening. |
|
Ok sounds good. Do you have any feedback on the direction or code so far? On Oct 27, 2016 4:56 AM, "Florent Vilmart" [email protected] wrote:
|
This PR is totally incomplete. Its an early proposal
Goal: add new push tracking capabilities to parse-server, specifically: track pushes and their status at the device level.
Objectives:
Proposed implementation:
PushPushobject is created per installation before sending to the PushAdapterPossible future extensions: