Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup for email in username field to match docs if email is undefined #2732

Merged
merged 3 commits into from
Sep 18, 2016

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Sep 18, 2016

Fixes #2502

When the email is not set on the user, the docs expressively says that the server should lookup in the username field.

This PR propose that change.

Note that the adapters should adapt to that change if implementing sendPasswordResetEmail, and lookup in the username field is email is not set.

If the adapter like parse-server-simple-mailgun-adapter only implements sendMail no change is required.

@ghost
Copy link

ghost commented Sep 18, 2016

@flovilmart updated the pull request - view changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants