Removes dependency upon babel-polyfills #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flovilmart
commented
Sep 18, 2016
•
flovilmart
commented
- Testsuite don't rely on babel-node that would inject polyfills into the environment
- kill switch if test are polyfilled (to ensure the lack of babel-polyfill at runtime won't cause issues)
- use lodash implementations if possible for array/object instance methods.
* Removes runtime dependency babel-polyfill * removes references to polyfilled array includes
ghost
added
the
flovilmart
commented
Sep 18, 2016
| @@ -14,6 +14,11 @@ global.on_db = (db, callback, elseCallback) => { | |||
| } | |||
| } | |||
|
|
|||
| if (global._babelPolyfill) { | |||
There was a problem hiding this comment.
make sure nothing is poly filled before running the tests
drew-gross
approved these changes
Sep 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.