Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved filename fixed so that clients display it correctly #2415 #2705

Merged
merged 4 commits into from
Sep 17, 2016
Merged

Saved filename fixed so that clients display it correctly #2415 #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e5e3dd
increased filename length to 36 to make sure clients display correct …
lama-buddy Sep 13, 2016
7ddf3e5
increased filename length to 36 to make sure clients display correct …
lama-buddy Sep 13, 2016
4d8551d
added uuid prefix to saved filenames
lama-buddy Sep 13, 2016
e67039f
Merge branch 'extend-uploaded-filename-length' of https://github.com/…
lama-buddy Sep 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"mime": "1.3.4",
"mongodb": "2.2.9",
"multer": "1.2.0",
"node-uuid": "^1.4.7",
"parse": "1.9.1",
"parse-server-fs-adapter": "1.0.1",
"parse-server-push-adapter": "1.1.0",
Expand Down
3 changes: 2 additions & 1 deletion src/Controllers/FilesController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import AdaptableController from './AdaptableController';
import { FilesAdapter } from '../Adapters/Files/FilesAdapter';
import path from 'path';
import mime from 'mime';
import uuid from 'node-uuid';

const legacyFilesRegex = new RegExp("^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}-.*");

Expand All @@ -26,7 +27,7 @@ export class FilesController extends AdaptableController {
contentType = mime.lookup(filename);
}

filename = randomHexString(32) + '_' + filename;
filename = uuid.v4() + '_' + filename;

var location = this.adapter.getFileLocation(config, filename);
return this.adapter.createFile(filename, data, contentType).then(() => {
Expand Down