Continue with postgres support #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@drew-gross updated the pull request. |
|
Can we test it? or it's still WIP? |
|
Still work in progress. The tests don't even run to completion successfully. |
… stringified objects (parse-community#1922)" reconfigure username/email tests Fix broken cloud code Save callback to variable undo Fix all tests where connections are left open after server closes. Fix issues caused by missing gridstore adapter remove uses of _collection reorder find() arguments Accept a database adapter as a parameter sudo maybe? use postgres username reorder find() arguments Build objects with default fields correctly Don't tell adapter about ACL WIP
WIP Notes on how to upgrade to 2.3.0 safely index on unique-indexes: c454180 Revert "Log objects rather than JSON stringified objects (parse-community#1922)" reconfigure username/email tests Start dealing with test shittyness most tests passing Make specific server config for tests async Fix more tests Save callback to variable undo remove uses of _collection reorder some params reorder find() arguments finishsh touching up argument order Accept a database adapter as a parameter First passing test with postgres! Fix tests Setup travis sudo maybe? use postgres username reorder find() arguments Build objects with default fields correctly Don't tell adapter about ACL WIP Passing postgres test with user Fix up createdAt, updatedAt, nad _hashed_password handling
…out how to run coverage on it.
Current coverage is 91.42%@@ master #2053 diff @@
==========================================
Files 93 93
Lines 6537 6692 +155
Methods 1169 1183 +14
Messages 0 0
Branches 1370 1401 +31
==========================================
+ Hits 6010 6118 +108
- Misses 527 574 +47
Partials 0 0
|
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
1 similar comment
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
1 similar comment
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move some mongo specific logic out of mongo adapter (createdAt/updatedAt/password stuff) and some non-mongo-specific stuff (query validation) out of mongo adapter.