Added Dockerfile #114
Closed
Added Dockerfile #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| # We run index.js, but you should update this to the main | ||
| # file defined in `main` in package.json | ||
| CMD node index.js |
There was a problem hiding this comment.
Really we should have a default working sample app.js file somewhere and use that. The image built by this Dockerfile should have a runnable parse-server container with minimal efforts.
There was a problem hiding this comment.
Ah... So, the parse-server-example is that, basically... and there's a Dockerfile there.
There was a problem hiding this comment.
The Dockerfile runs index.js which is the main file. I could add a test.js that creates an instance of ParseServer.
Also, parse-server-example does not have a Dockerfile.
|
Since this is just the router package, and not a full server, I think the Dockerfile should reside in parse-server-example. I just merged a PR there which added it. |
montymxb
pushed a commit
to montymxb/parse-server
that referenced
this pull request
Feb 14, 2016
Fix destroyAll with useMasterKey option
This was referenced Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #110