Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning on database listen #7624

Closed
4 tasks done
Moumouls opened this issue Oct 13, 2021 · 9 comments
Closed
4 tasks done

Deprecation warning on database listen #7624

Moumouls opened this issue Oct 13, 2021 · 9 comments
Labels
type:feature New feature or improvement of existing feature

Comments

@Moumouls
Copy link
Member

Moumouls commented Oct 13, 2021

New Issue Checklist

Issue Description

Database listen warning

Steps to reproduce

Start a parse server on master branch

Actual Outcome

Mongo listen database warning

Expected Outcome

No deprecation

Environment

5.0.0-alpha.1

Parse server need to listen directly on mongo client, not on the database. Source code of the warning

        const database = client.db(options.dbName);
        if (!database) {
          delete this.connectionPromise;
          return;
        }
        database.on('error', () => {
          delete this.connectionPromise;
        });
        database.on('close', () => {
          delete this.connectionPromise;
        });
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 13, 2021

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@Moumouls Moumouls added severity:low type:bug Impaired feature or lacking behavior that is likely assumed labels Oct 13, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021

Why did you consider a deprecation warning to be a bug?

@Moumouls
Copy link
Member Author

Moumouls commented Oct 13, 2021

From my point of view since a developer do not have control on this warning (specifically on mongo ones) it could be a bug. Parse Server need to be up to date about packages recommendations. Here this issue will spam developers CI (if they use some full server restarts)

here some example.

Capture d’écran 2021-10-13 à 17 29 28
)

Feel free to adjusts labels 🙂

@Moumouls
Copy link
Member Author

version: 5.0.0-alpha.1

@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021

A warning message is not a bug. A bug is a broken or impaired functionality, also see the label description.

@mtrezza mtrezza added type:improvement and removed type:bug Impaired feature or lacking behavior that is likely assumed severity:low labels Oct 13, 2021
@Moumouls
Copy link
Member Author

okay got it @mtrezza

@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021

Thanks, I have to admit though that these warning messages are annoying to the point that they seem like a bug, so emotionally I agree with you 🙂

@mtrezza
Copy link
Member

mtrezza commented Oct 17, 2021

Closing via #7626

@mtrezza mtrezza closed this as completed Oct 17, 2021
@Moumouls
Copy link
Member Author

Okay thanks @mtrezza for the last few things 🙂

@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

2 participants