Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprectation warning returnOriginal mongo #7623

Closed
4 tasks done
Moumouls opened this issue Oct 13, 2021 · 8 comments · Fixed by #7626
Closed
4 tasks done

Deprectation warning returnOriginal mongo #7623

Moumouls opened this issue Oct 13, 2021 · 8 comments · Fixed by #7626
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@Moumouls
Copy link
Member

Moumouls commented Oct 13, 2021 •
edited
Loading

New Issue Checklist

Issue Description

Getting

collection.findOneAndUpdate option [returnOriginal] is deprecated and will be removed in a later version.

Steps to reproduce

Pull master branch and run trigger findOneAndUpdate on db adapter

Actual Outcome

A lot of deprecation warnings

Expected Outcome

No warning

Environment

5.0.0-alpha.1

We need to replace returnOriginal with returnDocument as suggested here: https://jira.mongodb.org/browse/NODE-1812
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 13, 2021 •
edited
Loading

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@parse-github-assistant
Copy link

The label severity:low can only be used in combination with type:bug.

@Moumouls Moumouls added severity:low type:bug Impaired feature or lacking behavior that is likely assumed labels Oct 13, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 13, 2021 •
edited
Loading

Can you please add the parse server version to the issue to clarify. Master branch is changing constantly and an unclear reference. That's why we have alpha releases now.

Why did you consider a deprecation warning to be a bug?

@Moumouls
Copy link
Member Author

@mtrezza related: #7624 (comment)

@Moumouls
Copy link
Member Author

5.0.0-alpha.1

@mtrezza mtrezza added type:improvement and removed type:bug Impaired feature or lacking behavior that is likely assumed severity:low labels Oct 13, 2021
@Moumouls Moumouls mentioned this issue Oct 14, 2021
Merged
2 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 27, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: minor changes to remove mongo deprecation warnings Moumouls/parse-server
3 participants
@mtrezza @Moumouls @parseplatformorg