-
-
Notifications
You must be signed in to change notification settings - Fork 288
Conversation
Nice. Thanks for catching this! |
It's also in the |
Great! Can you squash 2 commits together? |
How would I best achieve that? (rebase?) Not too familiar with git. I guess I could submit a new pr |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Ok, got it, I had to configure sublime as the default git editor. Thanks for the help 👍 About the CLA, I've already submitted one, but I've changed my github username lately, so I'm waiting for them to update it. |
Sure, once the bot confirms the CLA signed - will merge in. |
@hhanesand I suggest you try re-accepting the CLA, or I won't be able to merge it in... |
@nlutsenko Accepted again with a different email |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Great. Merging in now. |
Defualt -> Default