This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
return a null object state from resolveMutation when a Destroy was issued #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the PR. Unfortunately, this will not work when there are other, pending mutations on the stack -- the Destroy needs to be properly merged into them, and the results need to be committed to the true state if the stack is completely compressed. A fix for #14 is coming with the v0.2 release, which should be out within the next day or so. |
|
Glad to hear it, sorry for not checking it more thoroughly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #14. Not sure if this was the intended behavior, but perhaps it can help fix this bug. It makes developing tedious if you're testing deletes from a list of items.