Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Fixing LiveQuery Parse Server error for empty "where" property. #197

Merged
merged 3 commits into from
Jul 27, 2019
Merged

Fixing LiveQuery Parse Server error for empty "where" property. #197

merged 3 commits into from
Jul 27, 2019

Conversation

noobs2ninjas
Copy link
Member

No description provided.

@dplewis
Copy link
Member

dplewis commented Jul 27, 2019

I gave you access, check your email.

I really should learn swift...

@noobs2ninjas
Copy link
Member Author

Thanks so much @dplewis! Anyone want to do me a solid and give me a quick code review so I can push a new release out?

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick nit. Also what is happening with the 2.6.0 release? Sorry I’m not up to date on it.

Sources/ParseLiveQuery/Internal/QueryEncoder.swift Outdated Show resolved Hide resolved
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Go ahead and squash and merge.

@noobs2ninjas noobs2ninjas reopened this Jul 27, 2019
@noobs2ninjas noobs2ninjas merged commit 71b2a69 into parse-community:master Jul 27, 2019
@dplewis
Copy link
Member

dplewis commented Jul 27, 2019

Thank you for contributing!

FYI in the future we try to allow the CI to build before we merge the PR. This ensures that CI is working and tests are passing. Also try to squash and merge instead of merging.

Screen Shot 2019-07-27 at 11 03 21 AM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants