Allows .or queries in LiveQuery #195
Conversation
|
@noobs2ninjas any interest in reviewing this? |
|
@TomWFox Yea this is great. I guess I cant really do it myself, but I was going to suggest some changes. Code formatting is a little rough. Would be great if we had a unit test for this. |
|
You should be able to request changes...
At some point I could work on getting you added as a committer which would make things a little easier. |
|
Actually nevermind. I was going to suggest formatting changes but I realized the entire documents that way. So I'll get in there and re-format everything later. @TomWFox could you do a release BTW its been ready for quite sometime. |
|
@noobs2ninjas see #188 |
|
We need to commit this. I got it figured out. |
|
@noobs2ninjas Sorry, are you saying this is good to go? - no changes needed? |
|
yup. i responded with what we need to do in the other thread. |
|
Guess my approve review doesn't automatically merge. |
Fixes #156, #47, and #85. Allows orQuery to be encoded without throwing.