Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on OkHttp 3.14 forces a minSdkVersion bump #113

Closed
jhansche opened this issue Jul 23, 2020 · 3 comments
Closed

Dependency on OkHttp 3.14 forces a minSdkVersion bump #113

jhansche opened this issue Jul 23, 2020 · 3 comments

Comments

@jhansche
Copy link
Contributor

Parse-SDK-Android specifically locks the version to < 3.13, because OkHttp 3.13 increases their minSdkVersion to 21 (Android 5.0). https://github.com/parse-community/Parse-SDK-Android/blob/master/parse/build.gradle#L31-L32

But #105 updated the OkHttp version to 3.14. I think the OkHttp version should be aligned between the two (might be resolved if/when #112 is completed), and if LiveQuery doesn't have a specific need for OkHttp 3.13, it should be similar locked to 3.12 for the same reason.

@Jawnnypoo
Copy link
Member

Good catch. This was a mistake when it was updated and we reverted it back in Parse-SDK-Android. Feel free to make a PR rolling this one back, or I can make one later today.

@jhansche
Copy link
Contributor Author

For reference, the Parse-SDK-Android issue pointing out the same: parse-community/Parse-SDK-Android#1005
And the commit that rolled it back: parse-community/Parse-SDK-Android@11feb41

I'll push a PR for this shortly

jhansche added a commit to wondrous-io/ParseLiveQuery-Android that referenced this issue Jul 23, 2020
OkHttp v3.13 bumps minSdkVersion to 21 (Android 5.0). To maintain maximum
compatibility, we can stick to OkHttp v3.12.
@jhansche
Copy link
Contributor Author

PR: #114

Jawnnypoo pushed a commit that referenced this issue Jul 23, 2020
OkHttp v3.13 bumps minSdkVersion to 21 (Android 5.0). To maintain maximum
compatibility, we can stick to OkHttp v3.12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants