Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating saved objects using saveAll #423

Merged
merged 5 commits into from
Oct 9, 2022
Merged

fix: updating saved objects using saveAll #423

merged 5 commits into from
Oct 9, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 9, 2022

New Pull Request Checklist

Issue Description

Cannot update saved ParseObject's using saveAll due to the SDK encoding the batched objects as Parse pointers.

Related issue: #405

Approach

Detect when batching and don't convert the ParseObject being saved to a Parse pointer.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 9, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@cbaker6 cbaker6 linked an issue Oct 9, 2022 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 90.17% // Head: 89.94% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (fe4a87e) compared to base (e415f21).
Patch coverage: 58.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   90.17%   89.94%   -0.24%     
==========================================
  Files         161      161              
  Lines       16189    16267      +78     
==========================================
+ Hits        14599    14631      +32     
- Misses       1590     1636      +46     
Impacted Files Coverage Δ
...ParseSwift/Objects/ParseInstallation+combine.swift 94.28% <ø> (ø)
...urces/ParseSwift/Objects/ParseObject+combine.swift 92.94% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.71% <ø> (ø)
Sources/ParseSwift/Types/Pointer.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseConfiguration.swift 39.18% <20.68%> (-13.88%) ⬇️
Sources/ParseSwift/Parse.swift 89.86% <22.22%> (-9.17%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 78.14% <87.50%> (+0.11%) ⬆️
Sources/ParseSwift/API/API+Command+async.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/API/API+Command.swift 89.84% <100.00%> (+0.27%) ⬆️
...urces/ParseSwift/API/API+NonParseBodyCommand.swift 81.59% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cbaker6 cbaker6 merged commit dc7666f into parse-community:main Oct 9, 2022
@cbaker6 cbaker6 deleted the deleteKeychain branch October 9, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a saved ParseObject using saveAll produces error
1 participant